Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Update minimum Python (3.9) and dependencies (SPEC 0 + 1yr) #1092

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[MAINT] Update minimum Python (3.9) and dependencies (SPEC 0 + 1yr) #1092

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8cf66c
drop python 3.8 and support 3.13
Remi-Gau Oct 8, 2024
546429c
fix dependencies
Remi-Gau Oct 8, 2024
b7e1c47
Apply suggestions from code review
Remi-Gau Oct 8, 2024
3cea2b9
Update pyproject.toml
effigies Oct 8, 2024
a7325bc
no 3.13
Remi-Gau Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,19 @@ jobs:
strategy:
matrix:
os: ['ubuntu-latest', 'macos-latest']
python-version: [3.8, 3.9, '3.10', '3.11', '3.12']
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
dependencies: ['full', 'pre']
include:
- os: ubuntu-latest
python-version: 3.8
python-version: '3.9'
dependencies: min
exclude:
# Drop pre tests for SPEC-0-unsupported Python versions
# See https://scientific-python.org/specs/spec-0000/
- python-version: '3.8'
dependencies: pre
- python-version: '3.9'
dependencies: pre
- python-version: '3.10'
dependencies: pre
fail-fast: false

env:
Expand Down
12 changes: 6 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build-backend = "setuptools.build_meta"
name = "pybids"
description = "bids: interface with datasets conforming to BIDS"
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = { file="LICENSE" }
authors = [
{ name = "PyBIDS Developers", email = "[email protected]" },
Expand All @@ -23,13 +23,13 @@ classifiers = [
"Topic :: Scientific/Engineering",
]
dependencies = [
"numpy >=1.19", # NEP29 + 1yr
"scipy >=1.5", # Scientific Python SPEC 0 + 1yr
"nibabel >=3.0",
"pandas >=0.25.2", # First with Py38 wheel
"numpy >=1.22", # SPEC 0 + 1yr (3yr)
"scipy >=1.8", # SPEC 0 + 1yr (3yr)
"nibabel >=4.0", # SPEC 0 + 1yr (3yr)
"pandas >=1.4.0", # SPEC 0 + 1yr (3yr)
"formulaic >=0.2.4, <0.6", # Tested on 0.2.4-0.5.2
"sqlalchemy >=1.3.16",
"bids-validator>=1.11", # Keep up-to-date to ensure support for recent modalities
"bids-validator>=1.14.12", # Keep up-to-date to ensure support for recent modalities
effigies marked this conversation as resolved.
Show resolved Hide resolved
"num2words >=0.5.5",
"click >=8.0",
"universal_pathlib >=0.2.2",
Expand Down
14 changes: 7 additions & 7 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,18 @@
requires =
tox>=4
envlist =
py3{8,9,10,11,12}-{full,pre}
py38-min
py3{9,10,11,12,13}-{full,pre}
py39-min
skip_missing_interpreters = true

# Configuration that allows us to split tests across GitHub runners effectively
[gh-actions]
python =
3.8: py38
3.9: py39
3.10: py310
3.11: py311
3.12: py312
3.13: py313

[gh-actions:env]
DEPENDS =
Expand All @@ -40,10 +40,10 @@ pass_env =
CLICOLOR_FORCE
extras = test
deps =
min: numpy ==1.19
min: scipy ==1.5
min: nibabel ==3.0
min: pandas ==0.25.2
min: numpy ==1.22
min: scipy ==1.8
min: nibabel ==4.0
min: pandas ==1.2.0
# Tested on 0.2.4-0.5.2
min: formulaic ==0.2.4
min: sqlalchemy ==1.3.16
Expand Down
Loading