Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added collaboration support in the editor #1213

Merged
merged 12 commits into from
Sep 5, 2024
Merged

Added collaboration support in the editor #1213

merged 12 commits into from
Sep 5, 2024

Conversation

sritabh
Copy link
Contributor

@sritabh sritabh commented Aug 27, 2024 •
edited
Loading

Description

Added support for collaborative editing in the editor with collaborative cursor.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 August 27, 2024 08:56 Inactive
@neetodeploy neetodeploy bot had a problem deploying to neeto-editor-ou1t-pr-1213 August 27, 2024 08:57 Failure
@sritabh
Added
f7b8b7a 
- Yjs to devDependency
- Refactored styling
- Added story
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 August 27, 2024 10:02 Inactive
@sritabh sritabh changed the title 5684 kb collaborative editor poc Added collaboration support in the editor Aug 27, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 August 27, 2024 10:11 Inactive
@sritabh sritabh added the minor Releases non-breaking noteworthy changes with backward compatible. label Aug 27, 2024
@sritabh sritabh self-assigned this Aug 27, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 August 27, 2024 10:53 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 August 28, 2024 06:23 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 September 2, 2024 13:13 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1213 September 3, 2024 12:33 Inactive
@sritabh
Copy link
Contributor Author

sritabh commented Sep 3, 2024 •
edited
Loading

@AbhayVAshokan _a Please review

@sritabh sritabh closed this Sep 3, 2024
@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned sritabh Sep 3, 2024
@sritabh sritabh reopened this Sep 3, 2024
@sritabh
Copy link
Contributor Author

sritabh commented Sep 3, 2024

Apologies
Assigning it to myself @sritabh _a till I verify changes in storybook in deployed PR app.

@neetogit-bot neetogit-bot bot assigned sritabh and unassigned AbhayVAshokan Sep 3, 2024
@sritabh sritabh marked this pull request as ready for review September 3, 2024 12:59
@sritabh
Copy link
Contributor Author

sritabh commented Sep 3, 2024 •
edited
Loading

@AbhayVAshokan _a Please review
I have added story for the collaboration example.

Instead of using prosemirror package directly, we're now using it from @tiptap/pm package. This ensures version compatibility which is required for extensions like collaboration-cursor to work properly.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned sritabh Sep 3, 2024
AbhayVAshokan
AbhayVAshokan approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👌

@sritabh _a: Please merge the PR yourself. We need to add yjs to the mentioned file so that the compliance add the dependency in every product.

package.json Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned sritabh and unassigned AbhayVAshokan Sep 5, 2024
@sritabh sritabh merged commit 6a94172 into main Sep 5, 2024
1 check passed
@sritabh sritabh deleted the 5684-kb-collaborative-editor-poc branch September 5, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@sritabh sritabh

Labels
minor Releases non-breaking noteworthy changes with backward compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for collaborative editing
2 participants
@sritabh @AbhayVAshokan