Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the Variables extension to render label when available. #1228

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Updated the Variables extension to render label when available. #1228

merged 3 commits into from
Oct 4, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 3, 2024 •
edited
Loading

Fixes #1217

Description

  • Renders the variable name while editing. The renderHtml is not changes, so the getHtml will still return the id.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 3, 2024
@deepakjosp deepakjosp self-assigned this Oct 3, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Oct 3, 2024
@AbhayVAshokan AbhayVAshokan mentioned this pull request Oct 3, 2024
Merged
4 tasks
AbhayVAshokan
AbhayVAshokan approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment •
edited by deepakjosp
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a

src/components/Editor/CustomExtensions/Variable/constants.js Outdated Show resolved Hide resolved
@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned AbhayVAshokan Oct 3, 2024
@deepakjosp deepakjosp changed the title Updated the Variables to extension to render label when available. Updated the Variables extension to render label when available. Oct 4, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1228 October 4, 2024 04:00 Inactive
@deepakjosp
Copy link
Contributor Author

#1228 (review)

@AbhayVAshokan the mentioned issue is not reproducible. The dropdown has a zIndex of 9999 by default. I'm merging the PR. I'll create an issue fix it if the issue is reproducible.

image

@deepakjosp deepakjosp merged commit 5843105 into main Oct 4, 2024
@deepakjosp deepakjosp deleted the 1217-add-a-isvariablesubstitutedaslabels-prop branch October 4, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@deepakjosp deepakjosp

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a isVariableSubstitutedAsLabels prop
2 participants
@deepakjosp @AbhayVAshokan