Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves the list item backspace behaviour. #1232

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Improves the list item backspace behaviour. #1232

merged 3 commits into from
Oct 5, 2024

Conversation

deepakjosp
Copy link
Contributor

@deepakjosp deepakjosp commented Oct 4, 2024 •
edited
Loading

Fixes #1216

Description
changes-to-backspace-bullets-editor

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1232 October 4, 2024 09:21 Inactive
@deepakjosp deepakjosp added the patch Releases small requests or bug fixes. label Oct 4, 2024
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a please review.

AbhayVAshokan
AbhayVAshokan requested changes Oct 4, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepakjosp _a: https://abhay-ashokan.neetorecord.com/watch/84c5ab6c-9c86-4f8d-82d5-e8be914b684a

@neetogit-bot neetogit-bot bot assigned deepakjosp and unassigned AbhayVAshokan Oct 4, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-editor-ou1t-pr-1232 October 4, 2024 16:06 Inactive
@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan I've fixed the mentioned issue. I've identified an issue with the sub items. I'll assign the PR back for review once I fix that.

@deepakjosp
Copy link
Contributor Author

@AbhayVAshokan _a fixed the identified edge case. Please review.

@neetogit-bot neetogit-bot bot assigned AbhayVAshokan and unassigned deepakjosp Oct 5, 2024
AbhayVAshokan
AbhayVAshokan approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@AbhayVAshokan AbhayVAshokan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👌

@AbhayVAshokan AbhayVAshokan merged commit d14b9f3 into main Oct 5, 2024
@AbhayVAshokan AbhayVAshokan deleted the 1216-improvement-to-the-list-item-backspace-behaviour branch October 5, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhayVAshokan AbhayVAshokan AbhayVAshokan approved these changes

Assignees

@AbhayVAshokan AbhayVAshokan

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improvement to the list item backspace behaviour
2 participants
@deepakjosp @AbhayVAshokan