Fixed toastId returning undefined when using Toastr.error (#2181)

bigbinary · May 7, 2024 · 6799863 · 6799863
1 parent 227b2cd
commit 6799863
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/src/components/Toastr/index.jsx b/src/components/Toastr/index.jsx
@@ -172,7 +172,7 @@ const withParsedErrorMsg =
     const { buttonLabel, onClick, customConfig } =
       parseToastrConfig(toastrConfig);
 
-    toastrFunc(errorMessage, {
+    return toastrFunc(errorMessage, {
       buttonLabel,
       onClick,
       role: "alert",

diff --git a/tests/Toastr.test.jsx b/tests/Toastr.test.jsx
@@ -375,9 +375,10 @@ describe("Toastr", () => {
     testToastrErrorMessages(errorResponse, expectedMessage);
   });
 
-  it("should return toastId when toastr is called", () => {
-    const successMessage = "This is a success toastr.";
-    const toastId = Toastr.success(successMessage);
-    expect(toastId).toBeDefined();
+  ["Success", "Info", "Warning", "Error"].forEach(type => {
+    it(`should return toastId when ${type} Toastr is called`, () => {
+      const toastId = Toastr[type.toLowerCase()](`This is a ${type} toastr.`);
+      expect(toastId).toBeDefined();
+    });
   });
 });
diff --git a/types/Toastr.d.ts b/types/Toastr.d.ts
@@ -4,7 +4,7 @@ type ToastrFunction = (
   message: React.ReactNode,
   buttonLabel?: React.ReactNode,
   onClick?: () => void
-) => void;
+) => string | null;
 
 const Toastr: {
   show: ToastrFunction;