Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bundling process #2134

Merged
merged 8 commits into from
Apr 1, 2024
Merged

Change bundling process #2134

merged 8 commits into from
Apr 1, 2024

Conversation

farhanlatheef
Copy link
Contributor

@farhanlatheef farhanlatheef commented Mar 25, 2024

Description

Checklist

- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
    - [ ] I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 25, 2024 09:17 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 26, 2024 00:31 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 26, 2024 00:34 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 26, 2024 01:04 Inactive
@farhanlatheef farhanlatheef added the patch Releases small requests or bug fixes. label Mar 26, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 26, 2024 06:06 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-pr-2134 March 26, 2024 06:09 Inactive
@farhanlatheef farhanlatheef marked this pull request as ready for review March 26, 2024 06:24
@farhanlatheef
Copy link
Contributor Author

@josephmathew900 _a

Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhanlatheef _a Added a minor suggestion. Rest LGTM.

Once the changes in this PR is released, please create an issue in neeto-molecules and raise a PR to fix the jest tests.

Screenshot 2024-04-01 at 7 32 40 AM

rollup.config.js Outdated Show resolved Hide resolved
@farhanlatheef farhanlatheef merged commit 8ccc9cc into main Apr 1, 2024
1 check passed
@farhanlatheef farhanlatheef deleted the 2131-bundle-process branch April 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve neetoUI bundling process
2 participants