Fixed not able to clear selections when bulk selected all row is true #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josephmathew900 _a Please review |
|
@farhanlatheef _a please review. |
|
@sritabh _a |
|
@farhanlatheef _a I have made the suggested changes and tested it in neetoForm, please review. |
farhanlatheef
approved these changes
Mar 29, 2024
farhanlatheef
deleted the
2150-allows-clearing-of-all-row-when-bulkSelectedAllRowsProps-is-passed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed: Clearing all rows by directly changing
selectedRowKeysnot working whenbulkSelectedAllRowsPropsis passed.Checklist
- [ ] I have made corresponding changes to the documentation.- [ ] I have updated the types definition of modified exports.- [ ] I have added tests that prove my fix is effective or that my feature works.- [ ] I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Reviewers