Support path import #2154
Merged
Support path import #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhanlatheef
added
the
minor
josephmathew900
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
LGTM. @farhanlatheef _a Add a description to the PR and then merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
import Button from 'neetoui/Button'Checklist
- [ ] I have made corresponding changes to the documentation.- [ ] I have added tests that prove my fix is effective or that my feature works.- [ ] I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Note
This PR need small change to product's
app/javascript/jsconfig.json."neetoui/*": ["../../node_modules/@bigbinary/neetoui/*"]"neetoui/*": ["../../node_modules/@bigbinary/neetoui/types/*"],
Reviewers