Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Datepicker minDate and maxDate #2157

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Fix Datepicker minDate and maxDate #2157

merged 8 commits into from
Apr 11, 2024

Conversation

farhanlatheef
Copy link
Contributor

@farhanlatheef farhanlatheef commented Apr 8, 2024 •
edited
Loading

Description
Fixed: antd Datepicker not validating minDate and maxDate on input date changes.

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 8, 2024 09:24 Inactive
@farhanlatheef farhanlatheef added the patch Releases small requests or bug fixes. label Apr 8, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 9, 2024 00:47 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 9, 2024 05:09 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 9, 2024 05:10 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 9, 2024 05:18 Inactive
@farhanlatheef farhanlatheef marked this pull request as ready for review April 9, 2024 05:23
@farhanlatheef
Copy link
Contributor Author

@josephmathew900 _a

josephmathew900

This comment was marked as outdated.

Sign in to view

josephmathew900
josephmathew900 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farhanlatheef _a Added a minor suggestion. Rest LGTM.

tests/DatePicker.test.jsx Outdated Show resolved Hide resolved
tests/DatePicker.test.jsx Outdated Show resolved Hide resolved
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 11, 2024 04:21 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2157 April 11, 2024 06:32 Inactive
@farhanlatheef farhanlatheef merged commit 76073c3 into main Apr 11, 2024
1 check passed
@farhanlatheef farhanlatheef deleted the 2155-date-min-max branch April 11, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@farhanlatheef farhanlatheef

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Antd allow typing date past minDate.
2 participants
@farhanlatheef @josephmathew900