-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move css to component scope #2168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farhanlatheef _a LGTM.
- As we discussed in the call, once this PR https://github.com/bigbinary/neeto-commons-frontend/pull/1139 is merged, either we should move the CSS of all the components to its respective files or we need to find a workaround for other components CSS to work.
- Add an empty stylesheet so that the
@import "@bigbinary/neetoui"
won't break. - I checked the bundle and everything LGTM. I don't see any code duplication. But check the HTML head also to ensure that multiple imports don't cause multiple styles to get inserted.
- Once this is done, please have a call with @praveen-murali-ind and explain the logic so that he can do further optimization.
@farhanlatheef CI is red. |
Found some edge cases of this approach.
I had a discussion with @josephmathew900 and @AbhayVAshokan regarding these issues. We will check the feasibility of purging the unused CSS instead of the component-scoped CSS approach. Closing this PR and related PRs in host applications. Will do a separate POC for purging CSS for more optimisations. |
Description
Checklist
- [ ] I have updated the types definition of modified exports.- [ ] I have added tests that prove my fix is effective or that my feature works.- [ ] I have added properdata-cy
anddata-testid
attributes.patch
/minor
/major
- If package publishis required).
Reviewers