Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to reset timestamp value to null using value prop #2182

Merged
merged 4 commits into from
May 9, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented May 8, 2024

Description

  • Added: ability to reset timestamp value to null using value prop

Checklist
- [ ] I have made corresponding changes to the documentation.
- [ ] I have updated the types definition of modified exports.

  • I have verified the functionality in some of the neeto web-apps.
    - [ ] I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@josephmathew900 _a

@gaagul gaagul added the patch Releases small requests or bug fixes. label May 8, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2182 May 8, 2024 05:22 Inactive
@gaagul
Copy link
Contributor Author

gaagul commented May 8, 2024

@gaagul _a

@neetogit-bot neetogit-bot bot assigned gaagul and unassigned josephmathew900 May 8, 2024
@gaagul gaagul marked this pull request as draft May 8, 2024 06:25
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2182 May 8, 2024 07:31 Inactive
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2182 May 8, 2024 07:33 Inactive
@gaagul gaagul marked this pull request as ready for review May 8, 2024 09:08
@gaagul
Copy link
Contributor Author

gaagul commented May 8, 2024

@josephmathew900 _a Please review.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned gaagul May 8, 2024
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit 1c98f42 into main May 9, 2024
1 check passed
@josephmathew900 josephmathew900 deleted the 2175-unable-to-reset-date-time-value-to-null branch May 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to reset timestamp/value to null for a controlled DateTimePicker component
2 participants