Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added onBlur handler for textarea to trim leading and trailing spaces #2183

Merged
merged 2 commits into from
May 8, 2024
Merged

Added onBlur handler for textarea to trim leading and trailing spaces #2183

merged 2 commits into from
May 8, 2024

Conversation

gaagul
Copy link
Contributor

@gaagul gaagul commented May 8, 2024

Description

  • Added: onBlur handler for textarea to trim leading and trailing spaces

Checklist

  • I have made corresponding changes to the documentation.
  • I have updated the types definition of modified exports.
  • I have verified the functionality in some of the neeto web-apps.
  • I have added tests that prove my fix is effective or that my feature works.
    - [ ] I have added proper data-cy and data-testid attributes.
  • I have added the necessary label (patch/minor/major - If package publish
    is required).

Reviewers

@gaagul _a

@gaagul gaagul added the patch Releases small requests or bug fixes. label May 8, 2024
@neetodeploy neetodeploy bot temporarily deployed to neeto-ui-kpyu-pr-2183 May 8, 2024 09:26 Inactive
@gaagul gaagul marked this pull request as ready for review May 8, 2024 09:27
@gaagul
Copy link
Contributor Author

gaagul commented May 8, 2024

@josephmathew900 _a , I have added the feature to trim leading and trailing whitespaces to work exactly like in neetoUI Input (https://neeto-ui.neeto.com/?path=/docs/components-input--docs). It trims leading and trailing spaces by default.

@neetogit-bot neetogit-bot bot assigned josephmathew900 and unassigned gaagul May 8, 2024
josephmathew900
josephmathew900 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@josephmathew900 josephmathew900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@josephmathew900 josephmathew900 merged commit c1c6901 into main May 8, 2024
1 check was pending
@josephmathew900 josephmathew900 deleted the 2171-trim-textarea-on-blur branch May 8, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmathew900 josephmathew900 josephmathew900 approved these changes

Assignees

@josephmathew900 josephmathew900

Labels
patch Releases small requests or bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim field value when TextArea field is blurred
2 participants
@gaagul @josephmathew900