Replaces boring avatar with avvvatars-react package. #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elated to the old implementation.
|
@praveen-murali-ind _a please review. Let's do a beta release and integrate it into one of the products. |
|
@deepakjosp CI is red. |
praveen-murali-ind
approved these changes
May 9, 2024
There was a problem hiding this comment.
@deepakjosp UI looks good to me. @josephmathew900 _a Could you please review.
josephmathew900
approved these changes
May 10, 2024
|
Published a beta release from this branch. |
…logic to render fist letters of firstname and lastname.
|
@deepakjosp CI is red. |
|
@josephmathew900 _a I've made changes as suggested by Neeraj in the ticket. Please review. |
josephmathew900
approved these changes
May 14, 2024
There was a problem hiding this comment.
@deepakjosp _a Added a minor suggestion. Please check. Rest LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/bigbinary/neeto-engineering-ui-ux/issues/275
Description
Replaces the boaring-avatar component with avvvatars-react component as the fallback avatar.
Checklist
I have made corresponding changes to the documentation.I have updated the types definition of modified exports.I have added tests that prove my fix is effective or that my feature works.I have added properdata-cyanddata-testidattributes.patch/minor/major- If package publishis required).
Reviewers