Streamable cart #1913
Merged
Streamable cart #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3db640e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
chanceaclark
approved these changes
Jan 16, 2025
|
|
||
| useEffect(() => { | ||
| if (lastResult?.error) { | ||
| console.log(lastResult.error); |
There was a problem hiding this comment.
Should we throw a toast here?
jorgemoya
reviewed
Jan 16, 2025
apledger
force-pushed
the
ap/streamable-cart
branch
from
69f6fb2 to
c6272e8
Compare
apledger
force-pushed
the
ap/streamable-cart
branch
from
c6272e8 to
5b0cf63
Compare
migueloller
approved these changes
Jan 25, 2025
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-canary-2thz3q3m2-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why?
Refactored Cart to use Streamable pattern. Also fixed positioning of Toaster.
Testing
CleanShot.2025-01-16.at.13.54.30.mp4