feat(payment): PAYPAL-5213 added messages implementation to Braintree PayPal Credit button strategy #2801
+65
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriiVitvitskyi1990
approved these changes
Mar 6, 2025
bc-nick
approved these changes
Mar 6, 2025
… PayPal Credit button strategy
serhii-tkachenko
force-pushed
the
PAYPAL-5213
branch
from
da7df33 to
5fffa50
Compare
serhii-tkachenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added messages implementation to Braintree PayPal Credit button strategy
Why?
Braintree Messaging is available only when Braintree PayPal Credit is enabled, so the best place to hold this implementation is in Braintree PayPal Credit Button strategy to render banner on cart page. So as part one of messages implementation migration the implementation was duplicated from Braintree PayPal to Braintree PayPal Credit button strategy
Testing / Proof
Unit tests
Manual tests
CI
US VPN location:
Non US VPN location:
