Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis use Grunt for unit testing instead of Ruby magic #2

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

inlet
Copy link

@inlet inlet commented Oct 9, 2013

Get rid of Ruby magic and use the power of Grunt & PhantomJS!

  • updated package.json (moved testing libs to devDependencies)
  • travis integration via node instead of ruby
  • added jasmine task to Gruntfile
  • added travis task to Gruntfile (on CI --verbose is added)
  • added gruntplugin grunt-contrib-jasmine
  • removed unused ruby shit

403026101098

@PaulTondeur
Copy link
Member

Nice, this is looking good. I like it that we no longer need Ruby!

A few remarks before we can merge this pull request:

  • You are using different coding setting. Please use these settings, as many of the proposed changes are just different indentations.
  • Could we also launch a browser and run the Jasmine tests? This would be super useful during development as we can use the browser to inspect things
  • Is there a way to exclude the change in the markdown, so we don't have to pollute our history with it, or is that just how it will work with git?
  • Would this approach also work with validating against the DOM? For example, navigator.js has a test that verifies that the DebugConsole gets wider if the current state is very wide. Would such test fail or succeed?

We can discuss/sort these things out in person/through skype if needed.

Again, really happy that we won't need to use Ruby in this solution and we can stick to just front-end tooling!

@PaulTondeur
Copy link
Member

ps. Is that @epologee in his younger years within the gif?

@inlet
Copy link
Author

inlet commented Oct 9, 2013

Hehe!

Op 9 okt. 2013 om 18:38 heeft PaulTondeur [email protected] het volgende geschreven:

ps. Is that @epologee in his younger years within the gif?


Reply to this email directly or view it on GitHub.

@inlet
Copy link
Author

inlet commented Oct 9, 2013

Thanks for the feedback! Let's discuss these things coming Sunday

Op 9 okt. 2013 om 18:37 heeft PaulTondeur [email protected] het volgende geschreven:

Nice, this is looking good. I like it that we no longer need Ruby!

A few remarks before we can merge this pull request:

You are using different coding setting. Please use these settings, as many of the proposed changes are just different indentations.
Could we also launch a browser and run the Jasmine tests? This would be super useful during development as we can use the browser to inspect things
Is there a way to exclude the change in the markdown, so we don't have to pollute our history with it, or is that just how it will work with git?
Would this approach also work with validating against the DOM? For example, navigator.js has a test that verifies that the DebugConsole gets wider if the current state is very wide. Would such test fail or succeed?
We can discuss/sort these things out in person/through skype if needed.

Again, really happy that we won't need to use Ruby in this solution and we can stick to just front-end tooling!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants