-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_TAGS for fine-grained tasks #703
Open
sg-wbi
wants to merge
20
commits into
bigscience-workshop:main
Choose a base branch
from
sg-wbi:finegrained_tasks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sg-wbi
requested review from
hakunanatasha,
jason-fries,
sunnnymskang,
ruisi-su,
galtay,
leonweber and
debajyotidatta
as code owners
June 8, 2022 14:10
The idea moving forward would be to attach specific tags to specific taks, this way we can have a test for this information, e.g. the "MULTIPLE_CHOICE" tag should be available only for "QA". |
One more thing: during the process I was tempted to create a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTRO
This introduces a metadata attribute
_TAGS
.The values in
_TAGS
are, well tags, to further classify the task.These tags are meant to be used together w/
_SUPPORTED_TASKS
.I tried to be as generic as possible in order to have a as minimal as possible set of tags, whose combination w/
_SUPPORTED_TASKS
could make sense.For instance,
bc5cdr
will have the following combination of fine-grained tasks:This is just a temporary solution and we can discuss which tags make sense and which do not.
HOW:
You can access these tags by checking out this PR:
As mentioned these tags are meant to be composed w/
_SUPPORTED_TASKS
:TROUBLESHOOTING:
The
BigBioConfigHelper
should load just fine. If this is not the case, it is probably because of a spelling error.To fix this you just need to edit the file you find in
If you find such errors, please ping me on slack and I will fix them right away.