Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup testing #57

Open
jaketae opened this issue Aug 19, 2021 · 2 comments
Open

Setup testing #57

jaketae opened this issue Aug 19, 2021 · 2 comments
Assignees

Comments

@jaketae
Copy link
Member

jaketae commented Aug 19, 2021

#56 set up a basic unit test, but we have to consider what kind of tests we want to run. This is especially important given that GitHub workflows does not have any GPU support, and will thus take a non-trivial amount of time to complete even a basic simple benchmark run. The proposal is to ideate some ways in which we could make tests modular and reasonably fast.

@jaketae
Copy link
Member Author

jaketae commented Aug 19, 2021

Also CC'ing @tianjianjiang for potential suggestions and input.

@tianjianjiang
Copy link
Contributor

@jaketae

Also CC'ing @tianjianjiang for potential suggestions and input.

take a non-trivial amount of time to complete even a basic simple benchmark run. The proposal is to ideate some ways in which we could make tests modular and reasonably fast.

Thanks for looping me in.

My two cents:

Personally, I tend to only test public interfaces at the highest level of a project's user stories. In this case, perhaps a separation: validate the data of each task, but test eval with small or even mock data as long as they are representative?

A benchmark run here indeed can be quite slow, and based on my recent experience with modeling-metadata repo, for a test of a roughly 5-iteration training with CPU via huggingface/accelerate, it took almost 1 minute to complete.

That said, I noticed that we may try to using load_dataset(streaming=True) for some dataset (if NOT in .gz), and sometimes we can even try to commit cached files via git-lfs as artifacts for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants