build: apply a typical project boilerplate of BigScience repo #56
Conversation
| {{"\n"}}Answer: | ||
| """ | ||
| """ # noqa W291 |
There was a problem hiding this comment.
Although the trailing whitespace after Answer: is understandable, load_dataset() may still remove it with tokenizer, cf. https://github.com/bigscience-workshop/evaluation/pull/56/files#r690616263
The noqa W291 is just to make flake8 happy. If the trailing whitespace can be removed from the template, then no need to have noqa here.
| {{"\n"}}Answer: | ||
| """ | ||
| """ # noqa W291 |
There was a problem hiding this comment.
| target-version = ['py38'] | ||
|
|
||
| [tool.pytest.ini_options] | ||
| filterwarnings = ["ignore:the imp module is deprecated in favour of importlib:DeprecationWarning:tensorflow.*"] |
There was a problem hiding this comment.
| authors = ["Your Name <[email protected]>"] | ||
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.8.11" |
There was a problem hiding this comment.
python>=3.8.10 supports Apple Silicon and macOS BigSur. (3.8.11 is just a bug-fixing version.)
Personally I'm not using them. Just to ensure no one will get surprised by an incompatible version.
|
|
||
| setup( | ||
| name="evaluation", | ||
| python_requires=">=3.8.11", |
There was a problem hiding this comment.
tianjianjiang
force-pushed
the
build-apply_project_boilerplate
branch
2 times, most recently
from
dbefb41
to
61bd30c
Compare
| assert ( | ||
| "Wound care encourages and speeds wound healing via cleaning and protection from reinjury or infection. " | ||
| "Depending on each patient's needs, it can range from the simplest first aid to entire nursing specialties " | ||
| "such as wound, ostomy, and continence nursing and burn center care.\n" | ||
| ) in prompt |
There was a problem hiding this comment.
This is just a demo, not really a good test case. For better test cases, perhaps more PRs wanted.
| "Depending on each patient's needs, it can range from the simplest first aid to entire nursing specialties " | ||
| "such as wound, ostomy, and continence nursing and burn center care.\n" | ||
| ) in prompt | ||
| assert prompt.endswith("Answer:") |
There was a problem hiding this comment.
The trailing whitespace is gone, cf. https://github.com/bigscience-workshop/evaluation/pull/56/files#r690593718.
Prepare GitHub actions for more regression tests in the future. A side note: Poetry is optional for managing venv and dependencies, but syncing requirements(-dev).txt must be done manually for now.
tianjianjiang
force-pushed
the
build-apply_project_boilerplate
branch
from
61bd30c
to
0381bcc
Compare
There was a problem hiding this comment.
Thanks for the PR. I generally agree with the line of changes you suggest, i.e. unit testing, GitHub workflows, and enforcing code style. Contrary to my original thought, the PR does not involve many merge conflicts (yet). Let's go ahead with the changes for now and brush up on the details as we go. LGTM!
Sorry for the late reaction. I could have left those style changes out but too late for that. Thank you for the understanding! |
related: #57
Prepare GitHub actions for more regression tests in the future.
A side note: Poetry is optional for managing venv and dependencies, but syncing requirements(-dev).txt must be done manually for now.
I will describe some details with code review comments.