Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes for changes introdueced when switching pull functions to query #188

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

Nicolai-vKuegelgen
Copy link
Contributor

The previous changed (PR #184 ) had some overlooked bugs, this should fix them.

@Nicolai-vKuegelgen Nicolai-vKuegelgen changed the title Fix: Fixes for changes introdueced when switching pull functions to query fix: Fixes for changes introdueced when switching pull functions to query Jul 11, 2023
@github-actions
Copy link
Contributor

Please format your code with black: make black.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4f46d4) 75.59% compared to head (ce9ea81) 75.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #188   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          98       98           
  Lines        7809     7806    -3     
=======================================
- Hits         5903     5901    -2     
+ Misses       1906     1905    -1     
Impacted Files Coverage Δ
cubi_tk/snappy/pull_processed_data.py 58.76% <ø> (+0.59%) ⬆️
cubi_tk/snappy/retrieve_irods_collection.py 25.39% <0.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@xiamaz xiamaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiamaz xiamaz merged commit 5fcc369 into main Jul 11, 2023
@xiamaz xiamaz deleted the fix-snappy-pull-functions branch July 11, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants