Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generic & cancer dataset #49

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

ericblanc20
Copy link
Contributor

  • Extends cubi_tk/snappy/pull_sheets.py to support datasets without Family, Father, Mother, Sex and/or Disease status as comments in the sample sheet.
  • mRNA_seq also added to supported library types.
  • The library name is used as default for the folder name when missing.

Note that the call to api.investigations.get is replaced by api.samplesheet.retrieve. I hope that it is correct...

@ericblanc20 ericblanc20 linked an issue Jun 25, 2021 that may be closed by this pull request
@eudesbarbosa
Copy link
Member

@ericblanc20, how did you test your changes? Is it something that could be used to stablish unit tests for SampleSheetBuilder?

@ericblanc20
Copy link
Contributor Author

@eudesbarbosa I just checked it worked with a cancer dataset that I needed to download.

Re SampleSheetBuilder: I don't know. I am not knowledgeable enough with the cubi-tk, Biomedsheets and altamisa code to judge.

It seems to me that samplesheet logic is hard-encoded in the different instance of IsaTabVisitor (in add_ped, pull_raw_data & pull_sheets). Without an overview of the whole projects (cubi-tk, Biomedsheets, altamisa, snappy), I find it difficult to write something more general & I just add what I need with the least amount of disruption to the rest of the code. (I should really learn more about those...)

@eudesbarbosa
Copy link
Member

@ericblanc20, implementing unit tests for this class doesn't look like a trivial task. I included a new ticket for it, #50.

@@ -155,7 +155,7 @@ def execute(self) -> typing.Optional[int]:
if not out_path.exists():
out_path.mkdir(parents=True)

investigation = api.investigations.get(
investigation = api.samplesheet.retrieve(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this affect the other sample sheet type?

@holtgrewe, care to comment? I'm not familiar with SODAR API syntax...

@eudesbarbosa
Copy link
Member

@ericblanc20 and @holtgrewe , if the sodar-cli.api part is okay I suggest we just merge - this might even solve #52 and #53. I can take Friday to work on the unit tests, #50.

@ericblanc20 ericblanc20 merged commit d5908c7 into master Jun 30, 2021
@ericblanc20 ericblanc20 deleted the feature/pull_generic_sheets branch June 30, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend pull sheets to generic & cancer datasets
2 participants