Test and refactor for cancel

lib/bike_brigade_web/controllers/authentication_controller.ex

@@ -50,13 +50,6 @@ defmodule BikeBrigadeWeb.AuthenticationController do
     end
   end
 
-  def show(conn, %{"cancel" => "true", "phone" => phone}) do
-    AuthenticationMessenger.clear_token(phone)
-
-    conn
-    |> redirect(to: ~p"/login")
-  end
-
   def show(conn, _params) do
     changeset = Ecto.Changeset.change(%Login{})
 
@@ -106,6 +99,13 @@ defmodule BikeBrigadeWeb.AuthenticationController do
     end
   end
 
+  def cancel(conn, %{"phone" => phone}) do
+    AuthenticationMessenger.clear_token(phone)
+
+    conn
+    |> redirect(to: ~p"/login")
+  end
+
   @doc "Set the session token and live socket for the user"
   def do_login(conn, user) do
     conn

lib/bike_brigade_web/controllers/authentication_html/show.html.heex

@@ -85,7 +85,8 @@
             <.button
               color={:white}
               class="w-full"
-              href={~p"/login?cancel=true&phone=#{@changeset.data.phone}"}
+              href={~p"/login?phone=#{@changeset.data.phone}"}
+              method="delete"
             >
               Cancel
             </.button>

lib/bike_brigade_web/core_components.ex

@@ -37,7 +37,7 @@ defmodule BikeBrigadeWeb.CoreComponents do
     values: [:none, :small, :normal, :medium, :full]
 
   attr :class, :string, default: nil
-  attr :rest, :global, include: ~w(href patch navigate disabled replace)
+  attr :rest, :global, include: ~w(href patch navigate disabled replace method)
   slot :inner_block, required: true
 
   @button_base_classes [

lib/bike_brigade_web/router.ex

@@ -84,6 +84,7 @@ defmodule BikeBrigadeWeb.Router do
 
     get "/login", AuthenticationController, :show
     post "/login", AuthenticationController, :login
+    delete "/login", AuthenticationController, :cancel
   end
 
   # this scope is for authenticated users that aren't dispatchers (ie: riders).

test/bike_brigade_web/controllers/authentication_controller_test.exs

@@ -55,5 +55,12 @@ defmodule BikeBrigadeWeb.AuthenticationControllerTest do
       conn = get(conn, ~p"/home")
       assert html_response(conn, 200) =~ "Welcome!"
     end
+
+    test "lets you cancel a login", %{conn: conn, user: user} do
+      conn = post(conn, ~p"/login", %{login: %{phone: user.phone}})
+      conn = delete(conn, ~p"/login", %{phone: user.phone})
+      assert redirected_to(conn) == ~p"/login"
+      assert Map.get(BikeBrigade.AuthenticationMessenger.get_state(), user.phone) == nil
+    end
   end
 end