Add: pr template #359
Merged
Add: pr template #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mveytsman
reviewed
May 9, 2024
.github/pull_request_template.md
Outdated
|
|
||
| - [ ] I have performed a self-review of my code | ||
| - [ ] If it is a core feature, I have added tests. | ||
| - [ ] Do we need to implement analytics? |
There was a problem hiding this comment.
I donno, it came from a template 🤷
Mostly, I think of it as—is there tracking that needs to be implemented alongside the business logic?
There was a problem hiding this comment.
I think it's maybe overkill - otherwise ship it?
There was a problem hiding this comment.
I think it's a bit open to interpretation so maybe not super helpful
sereprz
approved these changes
May 21, 2024
.github/pull_request_template.md
Outdated
|
|
||
| - [ ] I have performed a self-review of my code | ||
| - [ ] If it is a core feature, I have added tests. | ||
| - [ ] Do we need to implement analytics? |
There was a problem hiding this comment.
I think it's a bit open to interpretation so maybe not super helpful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have to write anything here because there is no template yet.
😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉 😉