Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show item name and description in signup #372

Conversation

mveytsman
Copy link
Member

We show the item name and description when signing up now. I used the description/summary thing with minimal styling - but honestly I think it's good for now.

Note also I got rid of the number when it's one item

Desktop

CleanShot 2024-05-22 at 16 36 34

Mobile

CleanShot 2024-05-22 at 16 35 21

Closes #364 #370

Copy link
Contributor

@teesloane teesloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. You could also add title attributes to the summary so that on mouse over we get alt text showing. But I think this is good to go now.

@mveytsman mveytsman merged commit cbace17 into main May 23, 2024
1 check passed
@mveytsman mveytsman deleted the 364-change-delivery-signup-to-show-the-name-of-the-item-being-delivered-instead-of-the-category branch May 23, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change delivery signup to show the name of the item being delivered (instead of the category)
2 participants