Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt if the rider is unassigning a delivery today #375

Conversation

mveytsman
Copy link
Member

@mveytsman mveytsman commented May 23, 2024

This uses the default confirm dialog to add a prompt if the user is cancelling a delivery today. I didn't add the prompt for texting since it's easier to do this as a first pass.

Closes #294 (for now)

Desktop

CleanShot 2024-05-23 at 18 28 33@2x

Mobile

image

Copy link
Contributor

@teesloane teesloane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

What do you thin about including the number to test in the alert copy?

@mveytsman mveytsman merged commit 946ca36 into main Jun 17, 2024
1 check passed
@mveytsman mveytsman deleted the 294-dont-allow-riders-to-unassign-themselves-within-n-hours-of-the-delivery branch June 17, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't allow riders to unassign themselves within N hours of the delivery
2 participants