fix: remove date filter when fetching campaign_ids #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, I added some needed padding on desktop.
( |
mveytsman
approved these changes
Jun 17, 2024
lib/bike_brigade/delivery.ex
Outdated
| # sometimes we just want to fetch campaigns with specific ids | ||
| # (such as when we need to display campaigns that urgently need a rider) | ||
| filter = | ||
| # First we check if we are fetching with campaign_ids |
There was a problem hiding this comment.
I love this but I feel we can refactor this into a with
Happy to pair on it!
mveytsman
requested changes
Jun 17, 2024
teesloane
force-pushed
the
ty/369-48-hour-cta
branch
from
aba590d
to
8cdc9b8
Compare
mveytsman
approved these changes
Jun 21, 2024
|
Will test this again just to be sure on sunday :) edit: oh wait... i added a test for this... but maybe I will still test on sunday. you know? Just to be sure? |
|
Did it work? |
I forgot to test yesterday 🙃 |
teesloane
force-pushed
the
ty/369-48-hour-cta
branch
from
a70e6c4
to
6fddf2d
Compare
|
@teesloane is this good to go? |
|
sorry, it's been a while and I forgot about this. I need to revisit the code to make sure I feel confident. I'll aim to merge it in on the weekend :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #369
Here is a video demonstrating the bug on a sunday, as well as the fix:
CleanShot.2024-06-16.at.09.28.59.mp4
Describe your changes
campaign_ids, we disable filtering by start/end date.@mveytsman any ideas on how I could write a test for this that simulates that it's a sunday locally and the campaigns in question are on a monday (without changing the system under test?)
Checklist before requesting a review
about this update in the description above.