Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing function clause. #390

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Conversation

teesloane
Copy link
Contributor

Describe your changes

Closes #355.

Technically, I suppose I could rename :new_campaign over on the program show.ex file, but I wasn't sure if it was there for a reason (as perhaps having just :new might imply it's for making a :new program ?

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added tests.
  • Are there other PRs or Issues that I should link to here?
  • Will this be part of a product update? If yes, please write one phrase
    about this update in the description above.

Copy link
Member

@mveytsman mveytsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but I think it's messy to bring in the new_campaign action from the program into the campaign form component

better would be to change the name of the action to :new when we load this component here: https://github.com/bikebrigade/dispatch/blob/main/lib/bike_brigade_web/live/program_live/show.html.heex#L87

I think that's the better separation of concerns

@teesloane teesloane requested a review from mveytsman June 28, 2024 19:17
@teesloane teesloane dismissed mveytsman’s stale review July 3, 2024 21:10

Adressed requests.

@teesloane teesloane merged commit 527bde0 into main Jul 7, 2024
1 check passed
@teesloane teesloane deleted the ty/355-new-campaign-from-program-age branch July 7, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants