Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

363 find a way to add images to delivery sign up #391

Merged
merged 11 commits into from
Jul 1, 2024

Conversation

mveytsman
Copy link
Member

@mveytsman mveytsman commented Jun 25, 2024

Describe your changes

Closes #363

Add images to programs

CleanShot 2024-06-25 at 17 00 46@2x

CleanShot 2024-06-25 at 17 05 18@2x

Update for dispatchers:

Hey folks, as requested you can now add photos to programs so we can show riders what the deliveries look like. I've gone ahead and updated the photos from the spreadsheet for

TODO:
- [ ] I think a generic description or notes would be good here. I think we have something in the db we should just expose it #392

  • Bug where when I delete a photo and upload a new one the deleted photo sticks around
  • Tests

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added tests.
  • Are there other PRs or Issues that I should link to here?
  • Will this be part of a product update? If yes, please write one phrase
    about this update in the description above.

@mveytsman mveytsman linked an issue Jun 25, 2024 that may be closed by this pull request
@teesloane
Copy link
Contributor

Looking good so far! Maybe let's add a small header above the photos on the campaign signup to say "Photos campaign delivery" or something better than that.

@mveytsman
Copy link
Member Author

Good idea!

CleanShot 2024-06-26 at 14 07 51@2x

@mveytsman mveytsman marked this pull request as ready for review June 26, 2024 19:15
@mveytsman mveytsman requested a review from teesloane June 26, 2024 19:15
@teesloane
Copy link
Contributor

Good idea!

CleanShot 2024-06-26 at 14 07 51@2x

I think I'd change "Campaign photos" to something a bit more descriptive:

Delivery examples

{Program name} usually delivers {Enum.join(program.items)}

Other than that, tested and good to go.

@mveytsman
Copy link
Member Author

I don't think they're always delivery examples though, eg sometimes they me be maps

May I'll leave it as photos of the delivery but not do the "usually delives" bit?

Also see #392

@mveytsman mveytsman force-pushed the 363-find-a-way-to-add-images-to-delivery-sign-up branch from 97dd673 to f1d9194 Compare June 27, 2024 21:33
@mveytsman
Copy link
Member Author

I realized #392 was already done, but I added a little photo description field to follow the spreadsheet example:

CleanShot 2024-06-27 at 17 55 13@2x

@mveytsman mveytsman merged commit 60446dc into main Jul 1, 2024
1 check passed
@mveytsman mveytsman deleted the 363-find-a-way-to-add-images-to-delivery-sign-up branch July 1, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Find a way to add images to delivery sign up
2 participants