Skip to content

Commit

Permalink
Merge pull request kubernetes#618 from MIBc/delete-todo
Browse files Browse the repository at this point in the history
Clear TODO comment in builder.go
  • Loading branch information
k8s-ci-robot authored Dec 14, 2018
2 parents 44f16f4 + 8872080 commit acc9a4f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ func main() {
glog.Info("Using default collectors")
collectorBuilder.WithEnabledCollectors(options.DefaultCollectors.AsSlice())
} else {
glog.Infof("Using collectors %s", opts.Collectors.String())
collectorBuilder.WithEnabledCollectors(opts.Collectors.AsSlice())
}

Expand Down Expand Up @@ -120,7 +121,7 @@ func main() {
})
}

glog.Infof("metric white- blacklisting: %v", whiteBlackList.Status())
glog.Infof("metric white-blacklisting: %v", whiteBlackList.Status())

collectorBuilder.WithWhiteBlackList(whiteBlackList)

Expand Down
1 change: 0 additions & 1 deletion pkg/collectors/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ func (b *Builder) Build() []*Collector {
activeCollectorNames = append(activeCollectorNames, c)
collectors = append(collectors, collector)
}
// TODO: What if not ok?
}

glog.Infof("Active collectors: %s", strings.Join(activeCollectorNames, ","))
Expand Down

0 comments on commit acc9a4f

Please sign in to comment.