changed formatting for unused kwargs error message

[jacobgolomb]

fixes issue #41

[ColmTalbot]

Thanks! We should probably also add a test for this, I'm not sure how straightforward it is to add tests for logged warnings.

[ColmTalbot]

It looks like there is support in pytest to capture log messages, e.g., here.

[ColmTalbot]

Ping @jacobgolomb

[jacobgolomb]

It looks like there is support in pytest to capture log messages, e.g., here.

Instead I just captured the logger output with the unittest context manager and added an assertion that the expected warning message is in the logger's output. Is that an okay alternative?

[ColmTalbot]

The new test looks good to me, happy to merge once the CI passes.

[jacobgolomb]

The new test looks good to me, happy to merge once the CI passes.

The unit test is failing in the CI, but passes locally for me:

>>> from source_test import TestLalBBH
>>> test = TestLalBBH()
>>> test.setUp()
>>> test.test_unused_waveform_kwargs_message()

[jacobgolomb]

The new test looks good to me, happy to merge once the CI passes.

The unit test is failing in the CI, but passes locally for me:

>>> from source_test import TestLalBBH
>>> test = TestLalBBH()
>>> test.setUp()
>>> test.test_unused_waveform_kwargs_message()

Maybe this could be due to self.parameters being updated before this specific test is run in CI and causing a different error to be raised first.

[ColmTalbot]

That's weird, have you tried running that full test class with pytest?

[ColmTalbot]

Actually, I feel like I remember reading that unittest log catching doesn't play well with pytest. That may be why I recommended pytest above.