[1.x] Update browser and device name detection for missing user agent #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milwad-dev
reviewed
Mar 29, 2024
There was a problem hiding this comment.
When the Detector class doesn't find any browser name return Unknown Device Name.
https://github.com/binafy/laravel-user-monitoring/blob/1.x/src/Utills/Detector.php#L71
https://github.com/binafy/laravel-user-monitoring/blob/1.x/src/Utills/Detector.php#L91
milwad-dev
changed the title
|
So why do I get this error message: |
|
The bug has been resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in our monitoring, it often happens that the user agent is not set, for example, with webhooks, 404 pages, etc. This PR checks if the $_SERVER variable is set and handles the error accordingly.