Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook #28

Merged
merged 9 commits into from
Sep 18, 2023
Merged

Add pre-commit hook #28

merged 9 commits into from
Sep 18, 2023

Conversation

dylan-myome
Copy link
Contributor

  • Use local black. isort, flake8 so that we can configure line length, etc
  • Fix testing by dropping python 3.8 support

@dylan-myome dylan-myome linked an issue Sep 18, 2023 that may be closed by this pull request
add precommit hook support #12
Closed
ecalifornica
ecalifornica approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ecalifornica ecalifornica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coooooool! 🚢

reece
reece approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@reece reece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... and I actually tried it!

Thanks Dylan.

@reece reece merged commit 596dc45 into main Sep 18, 2023
13 checks passed
@reece reece deleted the 12-add-precommit-hook-support branch September 18, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reece reece reece approved these changes

@ecalifornica ecalifornica ecalifornica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add precommit hook support
3 participants
@dylan-myome @reece @ecalifornica