Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update supported python versions to include 3.12 #42

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

korikuzma
Copy link
Contributor

close #38

  • support the 3 most recent python releases: 3.10, 3.11, 3.12

* support the 3 most recent python releases: 3.10, 3.11, 3.12
@korikuzma korikuzma self-assigned this Apr 2, 2024
@korikuzma korikuzma requested a review from a team as a code owner April 2, 2024 00:35
isolated_build = True

[gh]
python =
3.9 = py39, type
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the type was for. Do I need to add this back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO delete it here and discuss in #43

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9aa8d98) to head (b695995).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #42   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           18        18           
=========================================
  Hits            18        18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@korikuzma
Copy link
Contributor Author

@reece how can we update all repos with this change?

@reece
Copy link
Member

reece commented Apr 22, 2024

At maintainers meeting, agreed to upgrade repos to importlib (and remove pkg_resources) before supporting 3.12.

@reece reece changed the title build: update supported python versions build: update supported python versions to include 3.12 Apr 22, 2024
@reece reece marked this pull request as draft April 22, 2024 16:28
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@jsstevenson
Copy link
Contributor

jsstevenson commented Jun 4, 2024

I've created test PRs for most of the major repos (hesitant to do too much in UTA since I know it's undergoing a significant refactor). SeqRepo requires a temporary pin of setuptools until yoyo-migrations releases a new version (TBD?) but everything looks smooth otherwise. It'd be nice to start moving on this soon.

@korikuzma korikuzma marked this pull request as ready for review June 24, 2024 16:19
@korikuzma korikuzma requested a review from a team June 24, 2024 16:21
Copy link
Contributor

@jsstevenson jsstevenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@reece reece merged commit 4b53543 into main Jul 6, 2024
10 checks passed
@reece reece deleted the 38-update-supported-python-versions branch July 6, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep alive exempt issue from staleness checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update supported python versions
3 participants