switch Makefile to zsh and require zsh installation for developers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reece
commented
Jul 6, 2024
| @@ -44,7 +48,7 @@ ${VE_DIR}: | |||
| #=> develop: install package in develop mode | |||
| .PHONY: develop | |||
| develop: | |||
| pip install -e .[dev] | |||
| pip install -e ".[dev]" | |||
There was a problem hiding this comment.
N.B. zsh treats .[dev] as a glob. Because it doesn't match anything, it returns an error.
There was a problem hiding this comment.
I'm fairly certain that forgetting the quotes in zsh is considered a classic blunder
korikuzma
previously approved these changes
Jul 8, 2024
korikuzma
approved these changes
Jul 8, 2024
reece
deleted the
41-makefile-uses-bash-globstar-which-is-unavailable-to-older-bash-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biocommons Makefile had been using globstar for the clean* targets. This was much more reliable/less error prone/easier to read than find | xargs. However, Apple only installs bash v3 on Macs because of licensing concerns with bash v4. So, our options were:
Since this matter only is only relevant to developers, and because zsh is either already installed or easily installed on modern systems, the easiest move seems to be to require that developers install zsh. That's what this PR does.