Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ruff linter configuration #673

Closed
wants to merge 2 commits into from
Closed

Add ruff linter configuration #673

wants to merge 2 commits into from

Conversation

ecalifornica
Copy link
Member

Per @korikuzma's suggestion on #671, this adds a basic ruff configuration. This should be merged after the 18 errors are fixed.

Related:
#413

This was referenced Aug 26, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ecalifornica ecalifornica marked this pull request as ready for review August 26, 2023 04:59
This was referenced Sep 11, 2023
Merged
Merged
Merged
Closed
@reece
Copy link
Member

reece commented Sep 12, 2023 •
edited
Loading

How about:

  • set ruff line length = 100
  • set black line length = 100
  • reformat with make reformat
    ?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Nov 30, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Dec 7, 2023
@reece reece removed stale Issue is stale and subject to automatic closing closed-by-stale labels Dec 8, 2023
@reece reece reopened this Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Jan 8, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jan 15, 2024
@reece reece reopened this Feb 19, 2024
@reece reece requested a review from a team as a code owner February 19, 2024 17:45
@reece reece added resurrected and removed stale Issue is stale and subject to automatic closing labels Feb 19, 2024
@reece
Copy link
Member

reece commented Feb 19, 2024

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a one-time event.

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Mar 21, 2024
@ahwagner ahwagner removed the stale Issue is stale and subject to automatic closing label Mar 26, 2024
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the stale Issue is stale and subject to automatic closing label Apr 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this May 3, 2024
@reece
Copy link
Member

reece commented May 20, 2024

@ecalifornica : Thanks for contributing this. We're going to incorporate ideas from this PR into the template repo, and then propagate to project repos. biocommons/biocommons.example#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reece reece Awaiting requested review from reece

Assignees
No one assigned
Labels
closed-by-stale resurrected stale Issue is stale and subject to automatic closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecalifornica @reece @ahwagner