Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update idr, idr doesn't work with numpy > 1.19 #41293

Merged
merged 10 commits into from
Jun 3, 2023
Merged

Update idr, idr doesn't work with numpy > 1.19 #41293

merged 10 commits into from
Jun 3, 2023

Conversation

Maarten-vd-Sande
Copy link
Member

@Maarten-vd-Sande Maarten-vd-Sande commented Jun 2, 2023

I am having some issues with idr and newer numpy versions as they deprecated np.int for int. Also see:

nboley/idr#64 and kundajelab/idr#3

Somehow there were already builds higher than this one, so I had to go from 7 to 10


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@Maarten-vd-Sande
Copy link
Member Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jun 3, 2023
@Maarten-vd-Sande Maarten-vd-Sande removed the please review & merge set to ask for merge label Jun 3, 2023
@Maarten-vd-Sande
Copy link
Member Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jun 3, 2023
@bgruening bgruening merged commit d2d8688 into master Jun 3, 2023
@bgruening bgruening deleted the idr_patch branch June 3, 2023 21:57
@bgruening
Copy link
Member

Thanks @Maarten-vd-Sande

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants