-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "figure mode" button [WIP] #767
Draft
fedarko
wants to merge
9
commits into
biocore:master
Choose a base branch
from
fedarko:display-mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ebbf967
ENH: Add initial "display mode" btn #753
fedarko 2a706b1
ENH: Add circle glyph support - close #604
fedarko aa4b1e4
DOC: "display mode" -> "figure mode"
fedarko 9ae4f6c
DOC: fix figure mode tooltip
fedarko 9c4b5dc
TST: Un-break shape controller test
fedarko d1037fe
DOC: add ...more informative docs for circle func
fedarko 7725354
Merge branch 'master' of https://github.com/biocore/emperor into disp…
fedarko f83c8fe
Merge branch 'master' of https://github.com/biocore/emperor into disp…
fedarko 658ae05
Merge branch 'master' of https://github.com/biocore/emperor into disp…
fedarko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -106,6 +106,30 @@ define([ | |
}); | ||
}; | ||
|
||
/** | ||
* | ||
* Analogue of _resetAttribute() above, but makes everything a circle instead | ||
* | ||
* NOTE: In the future, making this pay more close attention to the current | ||
* shapes of each object (like how DecompositionView._buildVegaSpec() works) | ||
* may be preferable. However, that may require adding more 2D shape options | ||
* to Emperor. | ||
* | ||
* @extends EmperorAttributeABC | ||
* | ||
*/ | ||
ShapeController.prototype.makeEverythingACircle = function() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a unit test for this method? |
||
EmperorAttributeABC.prototype._resetAttribute.call(this); | ||
var scope = this; | ||
|
||
_.each(this.decompViewDict, function(view) { | ||
scope.setPlottableAttributes(view, 'Circle', view.decomp.plottable); | ||
view.needsUpdate = true; | ||
}); | ||
}; | ||
|
||
|
||
|
||
/** | ||
* Helper function to set the shape of plottable | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For updating different attributes of the axes controller, I would suggest using
scope.controllers.axes.fromJSON
, then you encode these attributes as an object and you should be good to go (see the unit tests for some examples).