This repository has been archived by the owner on Jul 29, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Add logging for qiita pushing #255
Open
wasade
wants to merge
10
commits into
biocore:master
Choose a base branch
from
wasade:charlies_pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 18, 2019
-
Propose we remove this TODO, as it's already been discussed in mail
Charles Cowart authored and Charles Cowart committedMar 18, 2019 Configuration menu - View commit details
-
Copy full SHA for 705cf64 - Browse repository at this point
Copy the full SHA 705cf64View commit details
Commits on Mar 19, 2019
-
Added logging to PushQiitaHandler
Logging for all methods within PushQiitaHandler has been added.
Charles Cowart authored and Charles Cowart committedMar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 4355182 - Browse repository at this point
Copy the full SHA 4355182View commit details -
Charles Cowart authored and Charles Cowart committed
Mar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 98182fa - Browse repository at this point
Copy the full SHA 98182faView commit details -
Charles Cowart authored and Charles Cowart committed
Mar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for e1810de - Browse repository at this point
Copy the full SHA e1810deView commit details -
Confirm data is getting marked
Local testing confirms marking SQL statement is not raising an Error. Speculating whether there needs to be time between the POST, and the immediate call afterward to the database directly.
Charles Cowart authored and Charles Cowart committedMar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 054fc34 - Browse repository at this point
Copy the full SHA 054fc34View commit details -
Locally, I can see the value for the sample ID are changing from N to Y, however, this unittest continues to fail. Increasing the wait time, or perhaps ensuring a commit occurs will change the result.
Charles Cowart authored and Charles Cowart committedMar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 6f42edf - Browse repository at this point
Copy the full SHA 6f42edfView commit details -
Wrapping contents of handler methods in try/except
As requested by Daniel. Confirm or deny an exception is going unseen
Charles Cowart authored and Charles Cowart committedMar 19, 2019 Configuration menu - View commit details
-
Copy full SHA for 8f5011e - Browse repository at this point
Copy the full SHA 8f5011eView commit details
Commits on Mar 21, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 19aa0ad - Browse repository at this point
Copy the full SHA 19aa0adView commit details
Commits on Apr 9, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e2f0bfb - Browse repository at this point
Copy the full SHA e2f0bfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6280a - Browse repository at this point
Copy the full SHA ed6280aView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.