-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry #541
base: main
Are you sure you want to change the base?
Conversation
I haven't used poetry myself, so please keep that in mind...
stricter pinning which seems to be promoted by the use of poetry seems nice, but we don't want pin too strictly as this library should be easy to add to other envs. |
Poetry is mamba compatible, poetry just completely replaces the old setup.py stuff. setup.py and setuptools also aren't recommended by PEP anymore So with this implementation you can run |
Realistically your env file could just then be
|
Poetry also has built in functionality for pushing and building straight to Pypy |
ah, so we can remove setup.py then? |
Exactly. |
As for the current error on ci, pip is supposed to work out of the box with pyproject tomls that have poetry in them, so I need to figure out why it's failing |
More generally I tend to only use conda for installing packages that don't work outright on pypi, like the cudatoolkit; which is usually compiled binaries I've found. |
Ahh, the good old dependency management fun-and-games 😅 I haven't used poetry extensively but my initial impressions are that it's reasonably good, and adding the option of using poetry seems like a good idea. On a related note, I'm keeping an eye on rye (rye-up.com), as it seems like it has a lot of potential to solve a lot of the python installation/distribution/dependency management issues. That said, it could end up being just another anaconda/mamba etc etc... Though Armin's contributions to the python ecosystem have been pretty solid in the past, so I'm hopeful about this latest one. |
still not 100% onboard, but doesn't look like it hurts, if you maintain it. |
Hi again,
Am I ok to add poetry dependency stuff to the pyproject toml?
Thanks
Craig