Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWSentimentAnalysis: implement support for Slovenian #366

Merged
merged 4 commits into from
Aug 2, 2018

Conversation

ajdapretnar
Copy link
Collaborator

@ajdapretnar ajdapretnar commented Aug 1, 2018

Issue

Partially implements #298.

Description of changes

Added Slovenian language resources for sentiment analysis that work with Liu Hu method.
Added Slovenian sentiment corpus KSS_1.001.
Tests.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 2, 2018

Codecov Report

Merging #366 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #366     +/-   ##
=========================================
- Coverage   85.24%   84.95%   -0.3%     
=========================================
  Files          33       34      +1     
  Lines        1871     1881     +10     
  Branches      337      337             
=========================================
+ Hits         1595     1598      +3     
- Misses        237      241      +4     
- Partials       39       42      +3

@ajdapretnar ajdapretnar requested a review from robertcv August 2, 2018 07:56
@@ -0,0 +1,13 @@
Source Created Category ID Content Source URL User
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the file name is a reference to the article but it has no meaning to the end-user. Could we think of a better one? Also, could we add this dataset with more than just 10 documents?

@@ -0,0 +1,13 @@
Source Created Category ID Content Source URL User
discrete time discrete string string string string
meta meta meta meta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set default text features

self.liu_hu = gui.appendRadioButton(box, "Liu Hu", addToLayout=False)
self.liu_lang = gui.comboBox(None, self, 'language',
sendSelectedValue=True,
items=[i for i in self.LANG],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make a new list?

@robertcv robertcv merged commit 523afb8 into biolab:master Aug 2, 2018
@ajdapretnar ajdapretnar deleted the slo-sentiment branch January 21, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants