Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Corpus: Unpickle corpus without language #919

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Nov 11, 2022

Issue

Corpuses, pickled before #916, cannot be used in Corpus widget, because they are missing a language property.

Description of changes
  • reimplement Corpus.setstate to add the language property
Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT requested a review from PrimozGodec November 11, 2022 09:15
@codecov-commenter
Copy link

Codecov Report

Merging #919 (d650aee) into master (5c55009) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   77.25%   77.23%   -0.02%     
==========================================
  Files          86       86              
  Lines       12115    12119       +4     
  Branches     1586     1587       +1     
==========================================
+ Hits         9359     9360       +1     
- Misses       2453     2454       +1     
- Partials      303      305       +2     

@PrimozGodec
Copy link
Collaborator

Thank you. It looks great. :)

@PrimozGodec PrimozGodec merged commit f969494 into biolab:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants