fix(noTypeOnlyImportAttributes): ignore .cts files

CHANGELOG.md

@@ -98,6 +98,23 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 
 - `noSuspiciousSemicolonInJsx` now catches suspicious semicolons in React fragments. Contributed by @vasucp1207
 
+- The syntax rule `noTypeOnlyImportAttributes` now ignores `.cts` files ([#4361](https://github.com/biomejs/biome/issues/4361)).
+
+  Since TypeScript 5.3, type-only imports can be associated to an import attribute in CommonJS-enabled files.
+  See the [TypeScript docs](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#stable-support-resolution-mode-in-import-types).
+
+  The following oce is no longer reported as a syntax error:
+
+  ```cts
+  import type { TypeFromRequire } from "pkg" with {
+      "resolution-mode": "require"
+  };
+  ```
+
+  Note that this is only allowed in files ending with the `cts` extension.
+
+  Contributed by @Conaclos
+
 ### CLI
 
 #### Enhancements

crates/biome_js_analyze/src/syntax/correctness/no_initializer_with_definite.rs

@@ -7,7 +7,7 @@ declare_syntax_rule! {
     ///
     /// ## Examples
     ///
-    /// ```js
+    /// ```ts
     /// let foo!: string = "bar";
     /// ```
     pub NoInitializerWithDefinite {

crates/biome_js_analyze/src/syntax/correctness/no_type_only_import_attributes.rs

@@ -1,3 +1,5 @@
+use std::os::unix::ffi::OsStrExt;
+
 use biome_analyze::{context::RuleContext, declare_syntax_rule, Ast, Rule, RuleDiagnostic};
 use biome_console::markup;
 use biome_js_syntax::{
@@ -8,11 +10,23 @@ use biome_rowan::{AstNode, AstSeparatedList, TextRange};
 declare_syntax_rule! {
     /// Disallow type-only imports and exports with import attributes.
     ///
+    /// there is one exception: TypeScript 5.3 and above allows this in CommonJS files.
+    /// See the [TypeScript docs](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-3.html#stable-support-resolution-mode-in-import-types).
+    ///
     /// ## Examples
     ///
-    /// ```js
+    /// ### Invalid
+    ///
+    /// ```ts
     /// import type { A } from "./a.json" with { type: "json" };
     /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```cts
+    /// import type { A } from "./a.json" with { "resolution-mode": "require" };
+    /// ```
+    ///
     pub NoTypeOnlyImportAttributes {
         version: "1.5.0",
         name: "noTypeOnlyImportAttributes",
@@ -27,6 +41,11 @@ impl Rule for NoTypeOnlyImportAttributes {
     type Options = ();
 
     fn run(ctx: &RuleContext<Self>) -> Self::Signals {
+        let extension = ctx.file_path().extension()?;
+        if extension.as_bytes() == b"cts" {
+            // Ignore `*.cts`
+            return None;
+        }
         let module_item = ctx.query();
         match module_item {
             AnyJsModuleItem::AnyJsStatement(_) => None,

crates/biome_js_analyze/tests/spec_tests.rs

@@ -13,8 +13,8 @@ use biome_test_utils::{
 use std::ops::Deref;
 use std::{ffi::OsStr, fs::read_to_string, path::Path, slice};
 
-tests_macros::gen_tests! {"tests/specs/**/*.{cjs,js,jsx,tsx,ts,json,jsonc,svelte}", crate::run_test, "module"}
-tests_macros::gen_tests! {"tests/suppression/**/*.{cjs,js,jsx,tsx,ts,json,jsonc,svelte}", crate::run_suppression_test, "module"}
+tests_macros::gen_tests! {"tests/specs/**/*.{cjs,cts,js,jsx,tsx,ts,json,jsonc,svelte}", crate::run_test, "module"}
+tests_macros::gen_tests! {"tests/suppression/**/*.{cjs,cts,js,jsx,tsx,ts,json,jsonc,svelte}", crate::run_suppression_test, "module"}
 
 fn run_test(input: &'static str, _: &str, _: &str, _: &str) {
     register_leak_checker();

crates/biome_js_analyze/tests/specs/correctness/noTypeOnlyImportAttributes/valid.cts

@@ -0,0 +1,3 @@
+import type { TypeFromRequire } from "pkg" with {
+    "resolution-mode": "require"
+};

crates/biome_js_analyze/tests/specs/correctness/noTypeOnlyImportAttributes/valid.cts.snap

@@ -0,0 +1,10 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid.cts
+---
+# Input
+```cts
+import type { TypeFromRequire } from "pkg" with {
+    "resolution-mode": "require"
+};
+```

crates/biome_js_analyze/tests/specs/correctness/noTypeOnlyImportAttributes/valid_cjs.package.json

@@ -0,0 +1,3 @@
+{
+    "type": "commonjs"
+}

crates/biome_js_analyze/tests/specs/correctness/noTypeOnlyImportAttributes/valid_cjs.ts

@@ -0,0 +1,3 @@
+import type { TypeFromRequire } from "pkg" with {
+    "resolution-mode": "require"
+};

crates/biome_js_analyze/tests/specs/correctness/noTypeOnlyImportAttributes/valid_cjs.ts.snap

@@ -0,0 +1,10 @@
+---
+source: crates/biome_js_analyze/tests/spec_tests.rs
+expression: valid_cjs.ts
+---
+# Input
+```cts
+import type { TypeFromRequire } from "pkg" with {
+    "resolution-mode": "require"
+};
+```