Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_css_parser): recognize multiple semicolons after declaration #4315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fireairforce
Copy link
Contributor

@fireairforce fireairforce commented Oct 17, 2024

Summary

closes: #3836

Test Plan

@github-actions github-actions bot added A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS labels Oct 17, 2024
@fireairforce fireairforce changed the title feat(biome_css_parser): parser should recognize multiple semicolons a… feat(biome_css_parser): recognize multiple semicolons after declaretion Oct 17, 2024
@github-actions github-actions bot added the A-Formatter Area: formatter label Oct 22, 2024
@fireairforce fireairforce marked this pull request as ready for review October 22, 2024 03:40
@fireairforce fireairforce changed the title feat(biome_css_parser): recognize multiple semicolons after declaretion feat(biome_css_parser): recognize multiple semicolons after declaration Oct 22, 2024
Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #4315 will not alter performance

Comparing fireairforce:fix-3836 (af67eaf) with main (a1ae7bf)

Summary

✅ 101 untouched benchmarks

@fireairforce
Copy link
Contributor Author

this mr is ready for review~

@ematipico
Copy link
Member

A couple of things:

@fireairforce
Copy link
Contributor Author

fireairforce commented Oct 22, 2024

ok, i will update the template later. i try to update the css.ungram like:

CssDeclarationWithSemicolon =
    declaration: CssDeclaration
    ';'*

But it will get an panic like:

image

And I've looked elsewhere and haven't seen similar writing methods. So i refer the statement JS_EMPTY_STAMENT of js parser and add a CSS_EMPTY_DECLARATION here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 CSS parser does not recognize multiple semicolons after a declaration
2 participants