Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Disallow all whitespace in filenames #1147

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

LJNeon
Copy link
Contributor

@LJNeon LJNeon commented Mar 8, 2024

Currently only the space character " " invalidates a filename, all other whitespace characters are allowed. This PR expands the invalid character list to include all whitespace and corrects all filenames with whitespace in existing saves.

This has been tested by @Fireball5939.

Copy link
Collaborator

@d0sboots d0sboots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this involves a savefile migration, it needs extra careful testing. Also, it should bump the savefile version.

src/Paths/Directory.ts Outdated Show resolved Hide resolved
@LJNeon
Copy link
Contributor Author

LJNeon commented Mar 8, 2024

How do I bump the version? Just increment 38 to 39? Anything else I need to do?

@d0sboots
Copy link
Collaborator

d0sboots commented Mar 8, 2024

Ye, just increment

src/SaveObject.ts Outdated Show resolved Hide resolved
@LJNeon LJNeon force-pushed the fixWhitespaceInFilenames branch from 1350f04 to 7f6f259 Compare February 9, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants