Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jade native psbt #753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Jade native psbt #753

wants to merge 1 commit into from

Conversation

JamieDriver
Copy link
Contributor

@JamieDriver JamieDriver commented Sep 3, 2024 •
edited
Loading

  1. latest jade api to recognise more recently added hw (now available as its own PR, jade: update Jade api to 1.0.33 #768)
  2. remove code which walked psbt and mapped it into Jade's legacy 'sign_tx' json format - instead pass PSBT directly to Jade for signing, since this has been supported in fw now for well over a year and seems to be working well.

@JamieDriver JamieDriver changed the title Jade native psbt wip: Jade native psbt Sep 3, 2024
@JamieDriver JamieDriver force-pushed the jade_native_psbt branch 3 times, most recently from 2f4319e to cf73f8c Compare September 4, 2024 10:06
@JamieDriver JamieDriver changed the title wip: Jade native psbt Jade native psbt Sep 5, 2024
This was referenced Sep 5, 2024
Open
Open
Open
Open
@brunoerg
Copy link
Contributor

brunoerg commented Sep 5, 2024

Concept ACK

@JamieDriver
Copy link
Contributor Author

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

@achow101
Copy link
Member

achow101 commented Sep 5, 2024

Thanks - any idea what's up with the CI ? Always feel more confident when CI looks good ...

You need to rebase.

@JamieDriver JamieDriver force-pushed the jade_native_psbt branch 4 times, most recently from c2e9632 to b8adf01 Compare September 10, 2024 11:23
@JamieDriver JamieDriver mentioned this pull request Sep 30, 2024
Open
@JamieDriver JamieDriver mentioned this pull request Oct 11, 2024
Closed
@JamieDriver
Copy link
Contributor Author

Probably best superseded by #763

@achow101
Copy link
Member

achow101 commented Dec 4, 2024

We prefer to support as old firmware as possible. This bumps the minimum supported firmware version, but it looks like it would be trivial to keep all of the old code while still using native PSBTs for newer firmware versions.

@JamieDriver
Copy link
Contributor Author

JamieDriver commented Dec 5, 2024 •
edited
Loading

Fair enough - I think I bumped the min version to 0.1.47, which was released in March 2023, so nearly 2 years old.
But ok, as you say supporting both is perfectly doable if we don't mind the ongoing maintenance overhead of legacy code.

I'll split the 'upgrade Jade api' off into it's own PR as that is more straightforward (and should be uncontentious now that #763 has been 'concept-nack'-ed) and is needed if HWI is to support the latest generation of Jade hardware.

Opened PR: #768

@JamieDriver
Copy link
Contributor Author

Rebased onto #768 (so this PR implicitly includes that PR), and retained support for legacy signing for old firmwares.
Thanks.

@achow101
Copy link
Member

Rebase for #768 and also there's an actual CI failure.

hwilib/devices/jade.py:380: error: Returning Any from function declared to return "PSBT"  [no-any-return]

@JamieDriver
jade: use Jade's native PSBT signing if the firmware version supports it
c66dd1a 
If Jade is running firmware 0.1.47 or later use native PSBT signing,
otherwise continue to use the existing legacy-format tx signing.
@JamieDriver
Copy link
Contributor Author

Addressed, many thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamieDriver @brunoerg @achow101