Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run_tests: fix coldcard path #754

Merged
merged 1 commit into from
Sep 4, 2024
Merged

run_tests: fix coldcard path #754

merged 1 commit into from
Sep 4, 2024

Conversation

brunoerg
Copy link
Contributor

@brunoerg brunoerg commented Sep 4, 2024 •
edited
Loading

@brunoerg brunoerg mentioned this pull request Sep 4, 2024
Merged
@hebasto
Copy link
Member

hebasto commented Sep 4, 2024

Maybe temporarily rebase this PR on top of #752, to properly test it in the CI?

@brunoerg brunoerg force-pushed the 2024-09-fix-coldcard branch from f6de874 to 83988d5 Compare September 4, 2024 16:50
@brunoerg
Copy link
Contributor Author

brunoerg commented Sep 4, 2024

Maybe temporarily rebase this PR on top of #752, to properly test it in the CI?

Done.

@brunoerg brunoerg force-pushed the 2024-09-fix-coldcard branch from 83988d5 to 244536f Compare September 4, 2024 17:16
@brunoerg brunoerg marked this pull request as ready for review September 4, 2024 17:16
@brunoerg
Copy link
Contributor Author

brunoerg commented Sep 4, 2024

Rebased

@achow101
Copy link
Member

achow101 commented Sep 4, 2024

ACK 244536f

@achow101 achow101 merged commit ad497de into bitcoin-core:master Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thompson1985 Thompson1985 Thompson1985 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brunoerg @hebasto @achow101 @Thompson1985