Added – Turkish Language v1.0 #853

zackha · 2022-01-18T11:03:33Z

Added – Turkish language option has been added and all pages have been translated into Turkish. ( 26dcc32 )

katesalazar · 2022-01-18T11:52:40Z

_data/languages.yml

@@ -3,3 +3,4 @@ zh_CN: 简体中文
 zh_TW: 繁體中文
 ja: 日本語
 es: Español
+tr: Turkish


yep türkçe (eng: Turkish)

Ok. the word has been replaced with its own language (5c8082c)

katesalazar · 2022-01-18T11:54:17Z

_data/navigation.yml

+  releases:
+    title: "Versiyonlar"
+    url:   "/tr/releases/"
+  faq:


You might have noticed, you can postpone FAQ for now,
there is a PR to remove them.

the code you show is releases, not FAQ

This is a dialogue created for a one line length code section
that only includes line 359, which reads: "faq". 😝

If GitHub or your browser or your mail viewer broke visuals,
that's on them. 😂

FAQ I'm postponing for now. If there is a fix, change or improvement you want, feel free to point it out. 👍

added rss pages

zackha

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

The property that is not in .scss lang has been removed.

katesalazar · 2022-01-18T16:21:34Z

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

Not really opposed, but mind your change from responsive.
Have you tested well different page widths?

katesalazar · 2022-01-18T17:57:02Z

_data/languages.yml

@@ -3,3 +3,4 @@ zh_CN: 简体中文
 zh_TW: 繁體中文
 ja: 日本語
 es: Español
+tr: Turkish


Suggested change

tr: Turkish

tr: Türkçe

oh of course 🤦‍♂️

zackha · 2022-01-18T18:14:39Z

Fix – bitcoin core logo aligned to menu by sick of symmetry (d8074a0)

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser not found any glitch.

The word Turkish has been replaced with its turkish equivalent (Türkçe).

katesalazar · 2022-01-18T18:27:37Z

...

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser and found not found any glitch.

Does the pic in div.site-name look good when li#langselect overflows
to the second row, under the "About" li?
In my browser that's a questionable alignment.
It's the only width that I've found worse for your change, though.

zackha · 2022-01-18T18:38:05Z

...

Not really opposed, but mind your change from responsive. Have you tested well different page widths?

Tested in different widths in responsive browser and found not found any glitch.

Does the pic in div.site-name look good when li#langselect overflows to the second row, under the "About" li? In my browser that's a questionable alignment. It's the only width that I've found worse for your change, though.

I think this looks better when we compare it to the old one. But much better, I can provide a professional touch with fully responsive.

The change will be made more professional.

katesalazar · 2022-01-18T20:00:59Z

_posts/tr/pages/2017-01-01-download.md

+pgp_key_fingerprint: "PGP anahtar parmak izi"
+verify_download: "İndirmenizi doğrulayın"
+
+verification_recommended: >


I wonder why can't I see the untranslated paragraphs that start here. 🤔

Download page completely translated in Turkish language (131d121)

I understand now, that coulda happened caused because of the
wrongly used version number fixed in 131d121 👌👌👌

Absolutely 🤗

indeed, just by setting the version 5 on top of that rev half translated,
the english untranslated paragraphs popped up 👌👌👌

katesalazar · 2022-01-18T20:01:39Z

_sass/page.scss

@@ -115,7 +115,6 @@ body {
 		a {
 			display: block;
 			padding: 10px 0;
-			decoration: none;


what does this change do?

The property (decoration) that is not in .css lang has been removed. I don't know why it was added either. (see. https://www.w3schools.com/cssref/)

katesalazar

Concept ACK,
only the Downloads page is preventing me full ACK.
Can't see the untranslated paragraphs displayed in the rendered page.
Dunno why they seemed to vanish.

zackha · 2022-01-19T07:14:27Z

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Same problem in Japanese. Now, with a new update, I am making the whole page completely in Turkish, like English and Spanish. Wait for the update.

zackha · 2022-01-19T08:57:45Z

Concept ACK, only the Downloads page is preventing me full ACK. Can't see the untranslated paragraphs displayed in the rendered page. Dunno why they seemed to vanish.

Download page completely translated in Turkish language (131d121)

katesalazar · 2022-01-19T09:44:54Z

_posts/tr/pages/2016-01-01-about.md

+type: pages
+layout: page
+lang: tr
+version: 1


I think the version change you made in 131d121#r64151455
applies here and maybe to other documents.

It was replaced with the version number of the English language version that I translated. (118a8de)

5 does not exist for this document, last is version 3, see:

bitcoincore.org/_posts/en/pages/2016-01-01-about.md

Line 8 in fabd138

version: 3

5 does not exist for this document, last is version 3, see:

bitcoincore.org/_posts/en/pages/2016-01-01-about.md

Line 8 in fabd138

version: 3

It was replaced with the version number of the English language version that I translated. (118a8de)

zackha · 2022-01-19T10:35:23Z

~~why did you change this?~~ (it was previously wrongly at 1)

The original is version 5 in the English document. I converted it from version 5.

katesalazar · 2022-01-19T11:57:46Z

I still don't understand why remove line:

bitcoincore.org/_sass/page.scss

Line 118 in fabd138

decoration: none;

otherwise,
ACK 2508deb

The branch revs are untidied up, but I also think extraordinary
and urgency circumstances concur justifying a looser merge
requirements for this particular PR

zackha · 2022-01-19T12:10:22Z

I still don't understand why remove line:

bitcoincore.org/_sass/page.scss

Line 118 in fabd138

decoration: none;

otherwise, ACK 2508deb

Because there is no property named decoration in .css Its absence does not constitute a deficiency. Current css renderers suggest a fix to the decoration property. (see. https://www.w3schools.com/cssref/)

katesalazar · 2022-01-19T12:14:20Z

Great, thanks.

ACK 2508deb

Thanks!

zackha · 2022-01-19T12:19:36Z

Great, thanks.

ACK 2508deb

Thanks!

You're welcome! I will update the header section next.

maflcko · 2022-02-03T15:07:33Z

_data/navigation.yml

+    title: "Versiyonlar"
+    url:   "/tr/releases/"
+  faq:
+    title: "FAQs"


this was removed

Thanks for the info, I'll revise it now...

Thanks. Removed faq nav (8985a37)

added – turkish language v1

26dcc32

katesalazar reviewed Jan 18, 2022

View reviewed changes

zackha added 2 commits January 18, 2022 16:40

added – turkish language v1.01

ec2b857

added rss pages

bitcoin core logo fixed

d8074a0

zackha commented Jan 18, 2022

View reviewed changes

removed non-property

68d81c6

The property that is not in .scss lang has been removed.

zackha changed the title ~~added – turkish language v1~~ added – turkish language and a few fixes v1 Jan 18, 2022

katesalazar reviewed Jan 18, 2022

View reviewed changes

Word, replaced by native language

5c8082c

The word Turkish has been replaced with its turkish equivalent (Türkçe).

change reverted

fbd6aeb

The change will be made more professional.

katesalazar reviewed Jan 18, 2022

View reviewed changes

zackha closed this Jan 19, 2022

zackha deleted the stable branch January 19, 2022 07:13

zackha restored the stable branch January 19, 2022 07:14

zackha reopened this Jan 19, 2022

Download page completely translated in Turkish language

131d121

katesalazar reviewed Jan 19, 2022

View reviewed changes

zackha added 2 commits January 19, 2022 13:49

Replaced with the version number of the translated language (eng).

118a8de

Updated with the translated language (eng.) version.

2508deb

katesalazar approved these changes Jan 19, 2022

View reviewed changes

zackha changed the title ~~added – turkish language and a few fixes v1~~ Added – Turkish Language v1.0 Jan 23, 2022

maflcko reviewed Feb 3, 2022

View reviewed changes

removed faq nav

8985a37

Added – Turkish Language v1.0 #853

Are you sure you want to change the base?

Added – Turkish Language v1.0 #853

Conversation

zackha commented Jan 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha Jan 18, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha left a comment • edited Loading

Choose a reason for hiding this comment

katesalazar commented Jan 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha commented Jan 18, 2022 • edited Loading

katesalazar commented Jan 18, 2022

zackha commented Jan 18, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

katesalazar left a comment

Choose a reason for hiding this comment

zackha commented Jan 19, 2022

zackha commented Jan 19, 2022

Choose a reason for hiding this comment

zackha Jan 19, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha commented Jan 19, 2022

katesalazar commented Jan 19, 2022 • edited Loading

zackha commented Jan 19, 2022 • edited Loading

katesalazar commented Jan 19, 2022

zackha commented Jan 19, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zackha Jan 18, 2022 •

edited

Loading

zackha left a comment •

edited

Loading

zackha commented Jan 18, 2022 •

edited

Loading

zackha Jan 19, 2022 •

edited

Loading

zackha Jan 19, 2022 •

edited

Loading

katesalazar commented Jan 19, 2022 •

edited

Loading

zackha commented Jan 19, 2022 •

edited

Loading