Translate unit names & fix external signer error #599
Conversation
|
Concept ACK. |
|
great idea |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Rebased (no changes, just had to re-generate the |
Mind rebasing this PR before soft translation string freeze? |
| //: Tooltip description of "BTC" unit in dropbox selector | ||
| case Unit::BTC: return tr("Bitcoins", "unit description"); | ||
| //: Tooltip description of "mBTC" unit in dropbox selector | ||
| case Unit::mBTC: return tr("Milli-Bitcoins (1 / 1" THIN_SP_UTF8 "000)", "unit description"); |
There was a problem hiding this comment.
It seems not passing to the translation file properly.
e414edd qt: Update translation source file (Hennadii Stepanov) b780095 qt: Adjust plural forms for translations (Hennadii Stepanov) 6ae8a24 GUI: Send: Make feerates translatable (Luke Dashjr) bd42f5e Bugfix: GUI: Send/PSBT: Correct virtual size unit and make translatable (Luke Dashjr) 1b0407f Bugfix: GUI: transactiondesc: Translate outlier "own address" and "watch-only" (Luke Dashjr) 170f312 GUI: Use translated external signer errors for messagebox text (Luke Dashjr) 9698959 GUI: Make messages for copying unsigned PSBTs translatable (Luke Dashjr) 08b8b28 Bugfix: GUI: Debug info: Use correct "kB" case for small mempool sizes, and make translation-friendly (Luke Dashjr) dacc322 GUI: PSBTOperationsDialog: Support translating window title (Luke Dashjr) 5a4fe55 GUI: Intro: Support translating caption of data directory chooser (Luke Dashjr) 3868ba3 GUI: Support translating peer network names (Luke Dashjr) f1f9811 GUI: Support translating address type dropdown entries (Luke Dashjr) Pull request description: This PR updates the `src/qt/locale/bitcoin_en.xlf` translation source file according to [Release schedule for 25.0](bitcoin/bitcoin#26549). Some translation-related fixes have been picked from #599 and #716. Note for reviewers: it is expected to get a zero diff after running `make -C src translate` locally. ACKs for top commit: jarolrod: ACK e414edd Tree-SHA512: 5b0c70db1e2f5871067e84f43ebea4ee4f0027fc5f2be49bbcb1d04e162ae76607b2b038e9d0622bcb5b3658d0ede8c10c4421ddaa3343f0e0be54315ca7a4f5
|
Most of commits from this PR were merged as a part of #724. |
luke-jr
changed the title
|
Rebased. Only units and the external signer bugfix remain. I didn't regenerate translations this time. |
…nal signer fails inexplicably
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
I think I got everything under src/qt missing translatability.
Exceptions:
Notably, I did include units. Not only for the benefit of non-Latin languages, but also we have "bits" and "sats" nowadays that likely make sense to translate even in Latin-based languages.
(Much of this was merged in #724 already)