Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blocking): get_with_retry is private method #100

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix(blocking): get_with_retry is private method #100

merged 1 commit into from
Sep 26, 2024

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Sep 25, 2024 •
edited
Loading

Clean up after #98 which accidentally exposed get_with_retry publicly for the blocking client.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11034104409

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.071%
Totals Coverage Status
Change from base Build 11025318001: 0.0%
Covered Lines: 1041
Relevant Lines: 1182
💛 - Coveralls

oleonardolima
oleonardolima approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bfaa9ae

@oleonardolima oleonardolima added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 25, 2024
@ValuedMammal ValuedMammal merged commit ae9edf9 into bitcoindevkit:master Sep 26, 2024
25 checks passed
@ValuedMammal ValuedMammal deleted the fix/blocking-retry branch October 3, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValuedMammal @coveralls @oleonardolima