Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all route hints in tagsObject #74

Closed

Conversation

bufo24
Copy link

@bufo24 bufo24 commented May 21, 2024

Previously routing_info in tagsObject only had 1 route hint, while this could be multiple regarding to the bolt11 spec.
I changed the routing_info to be an array inside the tagsObject.

I am aware of this being a breaking change, but I got quite confused that this was not an array before so I hope this change gives a more accurate representation of how route hints are being using in lightning invoices.

payreq.js Show resolved Hide resolved
@bufo24 bufo24 requested a review from junderw June 5, 2024 14:27
@junderw
Copy link
Member

junderw commented Jun 5, 2024

I don’t think this is a good idea.

This is a signed data structure. Messing around with order is never a good idea.

@junderw junderw closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants